Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] [Cases] Move configure cases component #95096

Merged
merged 9 commits into from
Mar 22, 2021
Merged

[Security Solution] [Cases] Move configure cases component #95096

merged 9 commits into from
Mar 22, 2021

Conversation

stephmilovic
Copy link
Contributor

@stephmilovic stephmilovic commented Mar 22, 2021 •
edited
Loading

Summary

Creates a new method, getConfigureCases, to expose the ConfigureCases component from CasesUi. The components got moved over in previous PR.

Closes #94129

New Cases UI Method

getConfigureCases

Arguments:

Property Description
userCanCrud boolean; user permissions to crud

UI component:
configure

@stephmilovic stephmilovic added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Feature:Cases Cases feature v7.13.0 Feature:Cases-RAC-UI labels Mar 22, 2021
@stephmilovic stephmilovic requested a review from a team as a code owner March 22, 2021 19:15
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@stephmilovic stephmilovic requested review from a team and michaelolo24 March 22, 2021 19:15
michaelolo24
michaelolo24 approved these changes Mar 22, 2021
View reviewed changes
Copy link
Contributor

@michaelolo24 michaelolo24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tested locally and was able to successfully load the flyout, connectors, and see the ITSM mapping details when initializing the ServiceNow connector

@stephmilovic stephmilovic merged commit 2c44d56 into elastic:cases_rac_ui Mar 22, 2021
@stephmilovic stephmilovic deleted the move_configure branch March 22, 2021 23:05
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

‼️ ERROR: no builds found for mergeBase sha [c3490d2]

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stephmilovic stephmilovic mentioned this pull request Apr 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelolo24 michaelolo24 michaelolo24 approved these changes

Assignees
No one assigned
Labels
Feature:Cases Cases feature release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stephmilovic @elasticmachine @kibanamachine @michaelolo24